Add automated screenshots #6089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify TestArchitectureTests class)
tobiasdiez
reviewed
Mar 10, 2020
| @Start | ||
| public void onStart(Stage stage) throws JabRefException { | ||
| final JabRefPreferences preferences = JabRefPreferences.getInstance(); | ||
| Globals.prefs = preferences; |
There was a problem hiding this comment.
Is it really necessary to overwrite the Globals.prefs ?
The current code also writes to the active preferences, which means that normal JabRef installations are affected as well.
There was a problem hiding this comment.
Overwriting: This basically is
. - I tried to start a full JabRef as the screenshots will show a complete JabRef and not some mocked part.Next step is to mock the preferences. Did not find out to do it in my JabRef timeslot (especially
caused me headaches. Why is it in the constructor?). (Refs #2768.) I think, whole JabRef has to be rewritten to rely on . Maybe, that is too much and I just have to mockJabRefPreferences.
Thus, I went for the quick way to show an end-to-end way to get screenshots. In case I cannot do that "in time", I would suggest to split up the PR: A) work on having a clean way for the preferences B) finish the basis for others to add new screenshots.
| JabRefGUI.getMainFrame().getOpenDatabaseAction().openFile(jabrefAuthorsBib, true); | ||
| // give database some time load | ||
| robot.interrupt(100); | ||
| DebugUtils.saveScreenshot(() -> ROOT.resolve("opened-database-dark-theme.png"), "").apply(stringBuilder); |
There was a problem hiding this comment.
The saveScreenshot(javafx.stage.Screen screen, ...) method should be more appropriate as you then capture only the JabRef window (instead of the complete screen).
Codecov Report
@@ Coverage Diff @@
## master #6089 +/- ##
============================================
- Coverage 41.52% 41.29% -0.24%
+ Complexity 6873 6842 -31
============================================
Files 1092 1092
Lines 46342 46337 -5
Branches 5563 5563
============================================
- Hits 19245 19133 -112
- Misses 25650 25758 +108
+ Partials 1447 1446 -1
Continue to review full report at Codecov.
|
|
The following needs to be done:
|
|
One more link for the ADR regarding the service loader: https://stackoverflow.com/q/16104786/873282 |
|
I think, #6089 (comment) was a show-stopper for me. Thus, no automated screenshots in 2020 |
5 tasks
koppor
pushed a commit
that referenced
this pull request
Jul 1, 2022
3d3573c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (#5988) 5de0fbe Update society-of-biblical-literature-fullnote-bibliography.csl (#5913) 04b6c7a Create revue-internationale-durbanisme.csl (#5974) 4a5bfe2 Update biological-reviews.csl (#6116) 957b2bc Update harvard-cite-them-right-no-et-al.csl (#6115) e836a6c Update harvard-university-of-bath.csl (#6011) b4a8dd7 Update and rename harvard-cite-them-right.csl to harvard-cite-them-ri… (#6113) a198884 Update twentieth-century-music.csl (#6110) 81c1619 Update archaeonautica.csl (#5928) fc46f1d Bump actions/cache from 2 to 3 (#6112) fab57ed Bump actions/checkout from 2 to 3 (#6111) 519d594 [don't merge] chore: Included githubactions in the dependabot config (#6109) a8aa898 Update universidade-estadual-de-alagoas-uneal-abnt.csl (#5915) 6191640 Update isnad-dipnotlu.csl (#5909) d65a6ac Update isnad-metinici.csl (#5910) 830d337 Update technische-universitat-dresden-linguistik.csl (#6097) 81adc43 Update american-society-for-horticultural-science.csl (#6089) b767623 Create south-african-law-journal.csl (#6092) 215e1e9 Create journal-of-lithic-studies.csl (#6080) 0740f8c Create eunomia-revista-en-cultura-de-la-legalidad.csl (#6095) f93c809 Create endocrine-journal.csl (#6086) 3fdeb51 Revert "chore: Set permissions for GitHub actions (#6096)" (#6108) 35ebd1e chore: Set permissions for GitHub actions (#6096) 1cb8758 Create journal-fur-medienlinguistik (#6100) f4b5f7f Update unified-style-sheet-for-linguistics.csl (#6098) c3f856a Update advanced-materials.csl (#6103) d1e7576 Bump diffy from 3.4.0 to 3.4.2 (#6107) 9e5e7ab Fix Dev Dynamics (#6099) 7234520 Add CSL style for the journal Developmental Dynamics (#6093) ba8db05 Create independent style for vox-sanguinis.csl (#6085) 845dee0 Create meta.csl (#6088) 684bc3a Update universite-du-quebec-a-montreal.csl (#6087) 3602c18 Up-date & re-title pour-reussir/dionne (#6043) 0cc6e82 Fix Mainz Geography cfc4cec Add DOI and fix printing author names in Population and Économie et statistique (#6079) 14e8b1d Update journal-of-neuroimaging.csl (#6084) 2c0e1f1 Update isnad-dipnotlu.csl (#6081) 02fdb9b Merge pull request #6082 from denismaier/patch-ube-muwi-note 9309378 removes default-locale git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 3d3573c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on creating automated screenshots to
builds/screenshots.